From: Angus Salkeld <asalkeld@redhat.com>
Date: Tue, 10 Apr 2012 04:13:06 +0000 (+1000)
Subject: Try harder to detach the server volume.
X-Git-Tag: 2014.1~2071
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=20c2b8891a1d129d9bb5ef254bb4a96b1a6fabf7;p=openstack-build%2Fheat-build.git

Try harder to detach the server volume.

It seems to need some encouragement.

Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
---

diff --git a/heat/engine/resources.py b/heat/engine/resources.py
index 5e965f16..c4c350f3 100644
--- a/heat/engine/resources.py
+++ b/heat/engine/resources.py
@@ -265,12 +265,17 @@ class VolumeAttachment(Resource):
                                                        self.instance_id)
 
         self.nova().volumes.delete_server_volume(self.t['Properties']['InstanceId'],
-                                                 self.t['Properties']['VolumeId'])
+                                                 self.instance_id)
 
         vol = self.nova('volume').volumes.get(self.t['Properties']['VolumeId'])
         while vol.status == 'in-use':
             print 'trying to un-attach %s, but still %s' % (self.instance_id, vol.status)
             eventlet.sleep(1)
+            try:
+                self.nova().volumes.delete_server_volume(self.t['Properties']['InstanceId'],
+                                                         self.instance_id)
+            except:
+                pass
             vol.get()
 
         self.state_set(self.DELETE_COMPLETE)