From: Zane Bitter <zbitter@redhat.com>
Date: Mon, 12 Aug 2013 09:12:33 +0000 (+0200)
Subject: Fail fast if Resource action methods are missing
X-Git-Tag: 2014.1~229^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=1ebc77bc04cac3ceb889a889e2266adaaccc5b06;p=openstack-build%2Fheat-build.git

Fail fast if Resource action methods are missing

If a resource is not actually a Resource with create(), delete() &c.
methods then something has gone horribly, horribly wrong. This is not a
priority for handling gracefully at runtime.

Change-Id: Iafce8e4a222677fc590bb579654e195dc4252a9e
---

diff --git a/heat/engine/parser.py b/heat/engine/parser.py
index 8d29dfe4..5cebd4dc 100644
--- a/heat/engine/parser.py
+++ b/heat/engine/parser.py
@@ -333,13 +333,9 @@ class Stack(object):
         def resource_action(r):
             # Find e.g resource.create and call it
             action_l = action.lower()
-            handle = getattr(r, '%s' % action_l, None)
-            if callable(handle):
-                return handle()
-            else:
-                raise exception.ResourceFailure(
-                    AttributeError(_('Resource action %s not found') %
-                                   action_l), r)
+            handle = getattr(r, '%s' % action_l)
+
+            return handle()
 
         action_task = scheduler.DependencyTaskGroup(self.dependencies,
                                                     resource_action,