From: Eugene Nikanorov <enikanorov@mirantis.com>
Date: Mon, 15 Sep 2014 18:10:45 +0000 (+0400)
Subject: Add missing methods to NoopFirewallDriver
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=0a64b61f8cbf41e1bf74961c235f03ac6cc6ead6;p=openstack-build%2Fneutron-build.git

Add missing methods to NoopFirewallDriver

The fix adds missing methods into generic Firewall class
and in NoopFirewall driver class.

Change-Id: I6402448075ed414434dc007f5c403fc85b6b1456
Closes-Bug: #1369685
Related-Bug: #1365806
(cherry picked from commit 9a6c073656a7e0b1a26b2bca0ba381489d04e322)
---

diff --git a/neutron/agent/firewall.py b/neutron/agent/firewall.py
index 7ce1f9920..8ce8e7b16 100644
--- a/neutron/agent/firewall.py
+++ b/neutron/agent/firewall.py
@@ -105,6 +105,14 @@ class FirewallDriver(object):
         finally:
             self.filter_defer_apply_off()
 
+    def update_security_group_members(self, sg_id, ips):
+        """Update group members in a security group."""
+        raise NotImplementedError()
+
+    def update_security_group_rules(self, sg_id, rules):
+        """Update rules in a security group."""
+        raise NotImplementedError()
+
 
 class NoopFirewallDriver(FirewallDriver):
     """Noop Firewall Driver.
@@ -134,3 +142,9 @@ class NoopFirewallDriver(FirewallDriver):
     @property
     def ports(self):
         return {}
+
+    def update_security_group_members(self, sg_id, ips):
+        pass
+
+    def update_security_group_rules(self, sg_id, rules):
+        pass