From: ZhiQiang Fan <aji.zqfan@gmail.com>
Date: Fri, 6 Sep 2013 05:27:19 +0000 (+0800)
Subject: Fix incorrect NotImplementedError
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=0739b2fe827b3beefb5ad81c063cbc4d00525a9d;p=openstack-build%2Fneutron-build.git

Fix incorrect NotImplementedError

neutron.common.exceptions doesn't define NotImplementedError, but
some codes still use it. We should use builtin
exceptions.NotImplementedError instead.

Note: this patch also fixes a never run code in nvp.

Closes-Bug: #1221500
Change-Id: I5f367ab5edc1e7fbbc2e4eba5fe36d148d4d062d
---

diff --git a/neutron/extensions/l3.py b/neutron/extensions/l3.py
index 62e1aee6c..8e95d3fdf 100644
--- a/neutron/extensions/l3.py
+++ b/neutron/extensions/l3.py
@@ -285,7 +285,7 @@ class RouterPluginBase(object):
         pass
 
     def get_routers_count(self, context, filters=None):
-        raise qexception.NotImplementedError()
+        raise NotImplementedError()
 
     def get_floatingips_count(self, context, filters=None):
-        raise qexception.NotImplementedError()
+        raise NotImplementedError()
diff --git a/neutron/plugins/nicira/NeutronPlugin.py b/neutron/plugins/nicira/NeutronPlugin.py
index af4a6ff4f..583412898 100644
--- a/neutron/plugins/nicira/NeutronPlugin.py
+++ b/neutron/plugins/nicira/NeutronPlugin.py
@@ -1086,11 +1086,9 @@ class NvpPluginV2(addr_pair_db.AllowedAddressPairsMixin,
 
     def update_network(self, context, id, network):
         pnet._raise_if_updates_provider_attributes(network['network'])
-        if network["network"].get("admin_state_up"):
-            if network['network']["admin_state_up"] is False:
-                raise q_exc.NotImplementedError(_("admin_state_up=False "
-                                                  "networks are not "
-                                                  "supported."))
+        if network["network"].get("admin_state_up") is False:
+            raise NotImplementedError(_("admin_state_up=False networks "
+                                        "are not supported."))
         with context.session.begin(subtransactions=True):
             net = super(NvpPluginV2, self).update_network(context, id, network)
             if psec.PORTSECURITY in network['network']:
diff --git a/neutron/tests/unit/nicira/test_nicira_plugin.py b/neutron/tests/unit/nicira/test_nicira_plugin.py
index 2be1b37f7..444eaf0fb 100644
--- a/neutron/tests/unit/nicira/test_nicira_plugin.py
+++ b/neutron/tests/unit/nicira/test_nicira_plugin.py
@@ -324,6 +324,15 @@ class TestNiciraNetworksV2(test_plugin.TestNetworksV2,
             self.assertEqual(webob.exc.HTTPServiceUnavailable.code,
                              res.status_int)
 
+    def test_update_network_with_admin_false(self):
+        data = {'network': {'admin_state_up': False}}
+        with self.network() as net:
+            plugin = manager.NeutronManager.get_plugin()
+            self.assertRaises(NotImplementedError,
+                              plugin.update_network,
+                              context.get_admin_context(),
+                              net['network']['id'], data)
+
 
 class NiciraPortSecurityTestCase(psec.PortSecurityDBTestCase):