From: shihanzhang <shihanzhang@huawei.com>
Date: Tue, 31 Dec 2013 07:22:40 +0000 (+0800)
Subject: Remove redundant codes
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=02f4516ad38c5deeefd686b87edf4bf06cffe5af;p=openstack-build%2Fneutron-build.git

Remove redundant codes

the code is redundant, it should be removed

Change-Id: I050bfc0b4d72037510dc2f3d729a564869a374c2
Closes-Bug: #1265132
---

diff --git a/neutron/db/l3_db.py b/neutron/db/l3_db.py
index ab6017f5c..71be3c41d 100644
--- a/neutron/db/l3_db.py
+++ b/neutron/db/l3_db.py
@@ -196,13 +196,12 @@ class L3_NAT_db_mixin(l3.RouterPluginBase):
             if fip_count:
                 raise l3.RouterExternalGatewayInUseByFloatingIp(
                     router_id=router_id, net_id=gw_port['network_id'])
-            if gw_port and gw_port['network_id'] != network_id:
-                with context.session.begin(subtransactions=True):
-                    router.gw_port = None
-                    context.session.add(router)
-                self._core_plugin.delete_port(context.elevated(),
-                                              gw_port['id'],
-                                              l3_port_check=False)
+            with context.session.begin(subtransactions=True):
+                router.gw_port = None
+                context.session.add(router)
+            self._core_plugin.delete_port(context.elevated(),
+                                          gw_port['id'],
+                                          l3_port_check=False)
 
         if network_id is not None and (gw_port is None or
                                        gw_port['network_id'] != network_id):