From: Wilson McCoubrey <wilson@puppet.com>
Date: Thu, 16 Mar 2017 11:27:49 +0000 (+0000)
Subject: [MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
X-Git-Tag: 2.4.0~3^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;ds=sidebyside;h=refs%2Fheads%2FMODULES-4528;p=puppet-modules%2Fpuppetlabs-apt.git

[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
---

diff --git a/spec/defines/setting_spec.rb b/spec/defines/setting_spec.rb
index e1163a0..c0aad8e 100644
--- a/spec/defines/setting_spec.rb
+++ b/spec/defines/setting_spec.rb
@@ -95,7 +95,7 @@ describe 'apt::setting' do
 
     context 'with priority=1.2' do
       let(:params) { default_params.merge({ :priority => 1.2 }) }
-      if Puppet.version.to_f >= 4.0 || ENV["FUTURE_PARSER"] == 'yes'
+      if Puppet::Util::Package.versioncmp(Puppet.version, '4.0') >= 0 || ENV["FUTURE_PARSER"] == 'yes'
         it { is_expected.to compile.and_raise_error(/input needs to be a String/) }
       else
         it { is_expected.to compile.and_raise_error(/priority must be an integer or a zero-padded integer/) }