]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
change name to fetch_os_name skip_bytecode_test_oracle7
authoradrianiurca <adrian.iurca@gmail.com>
Mon, 16 Nov 2020 21:23:30 +0000 (23:23 +0200)
committeradrianiurca <adrian.iurca@gmail.com>
Mon, 16 Nov 2020 21:23:30 +0000 (23:23 +0200)
spec/acceptance/firewall_attributes_exceptions_spec.rb
spec/spec_helper_acceptance_local.rb

index a107e53ac08e63555fed58122c05d71418da1afa..426c500f958820db9f1cda5089a30bd2e8dc4850 100644 (file)
@@ -19,7 +19,7 @@ describe 'firewall basics', docker: true do
   # Skipping those from which we know they would fail.
   describe 'bytecode property', unless: (os[:family] == 'redhat' && os[:release][0] <= '6') ||
                                         (os[:family] == 'sles' && os[:release][0..1] <= '11') ||
-                                        (get_os_name == 'oraclelinux' && os[:release][0] <= '7') ||
+                                        (fetch_os_name == 'oraclelinux' && os[:release][0] <= '7') ||
                                         (os[:family] == 'ubuntu') do
     describe 'bytecode' do
       context '4,48 0 0 9,21 0 1 6,6 0 0 1,6 0 0 0' do
index b6d58ef0a94d11f0f4fdc2d026a41d6f5281c934..532d532a158493a0ebb69e6a951eb4c37663b42a 100644 (file)
@@ -43,7 +43,7 @@ def update_profile_file
   run_shell("sed -i '/mesg n || true/c\\test -t 0 && mesg n || true' ~/.profile")
 end
 
-def get_os_name # rubocop:disable Style/AccessorMethodName: Do not prefix reader method names with get_
+def fetch_os_name
   @facter_os_name ||= run_shell('facter os.name').stdout.delete("\n").downcase
 end