]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
LIO: Use rtslib property instead of private method
authorEric Harney <eharney@redhat.com>
Tue, 17 Mar 2015 16:36:01 +0000 (12:36 -0400)
committerEric Harney <eharney@redhat.com>
Thu, 7 May 2015 14:27:38 +0000 (10:27 -0400)
We should not use private methods from a dependent library.

Change-Id: Idc0398ccd2974c56ac95294d6549b60c367a7338

cinder/cmd/rtstool.py

index 4ec404a9ec6a3bf7c988cbbd14d970c20338b02c..c132f28f39c42fb2f3ade0caed0911989ee6c779 100644 (file)
@@ -77,7 +77,7 @@ def create(backing_device, name, userid, password, iser_enabled,
 
     try:
         if iser_enabled == 'True':
-            portal._set_iser(1)
+            portal.iser = True
     except rtslib.utils.RTSLibError:
         print(_('Error enabling iSER for NetworkPortal: please ensure that '
                 'RDMA is supported on your iSCSI port.'))