]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Give better error to client on server 500 error
authorDan Wendlandt <dan@nicira.com>
Sun, 9 Sep 2012 05:18:39 +0000 (22:18 -0700)
committerDan Wendlandt <dan@nicira.com>
Sun, 9 Sep 2012 05:18:39 +0000 (22:18 -0700)
bug 1048109

Change-Id: Iaaa187a7868ee6227315b9c3354b424fe7c42508

quantum/api/v2/resource.py

index adf574e90e724176bde71011098bbaa4c6a2c841..560ac52e9db341738280760e8e2a39a7c0eb9fe8 100644 (file)
@@ -109,7 +109,10 @@ def Resource(controller, faults=None, deserializers=None, serializers=None):
         except Exception as e:
             # NOTE(jkoelker) Everyting else is 500
             LOG.exception('%s failed' % action)
-            body = serializer({'QuantumError': str(e)})
+            # Do not expose details of 500 error to clients.
+            msg = _('Request Failed: internal server error while '
+                    'processing your request.')
+            body = serializer({'QuantumError': msg})
             kwargs = {'body': body, 'content_type': content_type}
             raise webob.exc.HTTPInternalServerError(**kwargs)