Python3: replace 'unicode' with 'six.text_type'

In Python 3, 'unicode' does not exist; 'six.text_type' should be used instead.

Change-Id: I71011b4beee9817a61278eb473804cfb798de74a
Blueprint: neutron-python3

diff --git a/neutron/agent/metadata/agent.py b/neutron/agent/metadata/agent.py
index e2cad9c9ace22daeeef4d17b026a4c519b453ff6..769d8039bc043229eb2b730fb79a222f4071af08 100644 (file)
--- a/neutron/agent/metadata/agent.py
+++ b/neutron/agent/metadata/agent.py
@@ -20,6 +20,7 @@ from neutronclient.v2_0 import client
 from oslo_config import cfg
 from oslo_log import log as logging
 import oslo_messaging
+import six
 import six.moves.urllib.parse as urlparse
 import webob
 
@@ -116,7 +117,8 @@ class MetadataProxyHandler(object):
             LOG.exception(_LE("Unexpected error."))
             msg = _('An unknown error has occurred. '
                     'Please try your request again.')
-            return webob.exc.HTTPInternalServerError(explanation=unicode(msg))
+            explanation = six.text_type(msg)
+            return webob.exc.HTTPInternalServerError(explanation=explanation)
 
     def _get_ports_from_server(self, router_id=None, ip_address=None,
                                networks=None):
@@ -257,7 +259,8 @@ class MetadataProxyHandler(object):
                 'Remote metadata server experienced an internal server error.'
             )
             LOG.warn(msg)
-            return webob.exc.HTTPInternalServerError(explanation=unicode(msg))
+            explanation = six.text_type(msg)
+            return webob.exc.HTTPInternalServerError(explanation=explanation)
         else:
             raise Exception(_('Unexpected response code: %s') % resp.status)
 

diff --git a/neutron/agent/metadata/namespace_proxy.py b/neutron/agent/metadata/namespace_proxy.py
index e84a256de69142780d0ee227fd299f6919ae7716..d68cb2493a559a5a6ee89a2137d98c4d6e407128 100644 (file)
--- a/neutron/agent/metadata/namespace_proxy.py
+++ b/neutron/agent/metadata/namespace_proxy.py
@@ -15,6 +15,7 @@
 import httplib2
 from oslo_config import cfg
 from oslo_log import log as logging
+import six
 import six.moves.urllib.parse as urlparse
 import webob
 
@@ -56,7 +57,8 @@ class NetworkMetadataProxyHandler(object):
             LOG.exception(_LE("Unexpected error."))
             msg = _('An unknown error has occurred. '
                     'Please try your request again.')
-            return webob.exc.HTTPInternalServerError(explanation=unicode(msg))
+            explanation = six.text_type(msg)
+            return webob.exc.HTTPInternalServerError(explanation=explanation)
 
     def _proxy_request(self, remote_address, method, path_info,
                        query_string, body):
@@ -103,7 +105,8 @@ class NetworkMetadataProxyHandler(object):
                 'Remote metadata server experienced an internal server error.'
             )
             LOG.debug(msg)
-            return webob.exc.HTTPInternalServerError(explanation=unicode(msg))
+            explanation = six.text_type(msg)
+            return webob.exc.HTTPInternalServerError(explanation=explanation)
         else:
             raise Exception(_('Unexpected response code: %s') % resp.status)
 

diff --git a/neutron/api/extensions.py b/neutron/api/extensions.py
index fa275bfe02f0abc362fd6c8bf642bf5c792af42e..f6b4601ba2157a50d936c62c6973ab21bb8bea51 100644 (file)
--- a/neutron/api/extensions.py
+++ b/neutron/api/extensions.py
@@ -506,7 +506,8 @@ class ExtensionManager(object):
             LOG.debug('Ext namespace: %s', extension.get_namespace())
             LOG.debug('Ext updated: %s', extension.get_updated())
         except AttributeError as ex:
-            LOG.exception(_LE("Exception loading extension: %s"), unicode(ex))
+            LOG.exception(_LE("Exception loading extension: %s"),
+                          six.text_type(ex))
             return False
         return True
 

diff --git a/neutron/common/exceptions.py b/neutron/common/exceptions.py
index 5d29d2afe04644d18a779af7796bd50bd0e7aaa7..c6ec6ccca5407117f89eff47a7a0d4ee074766c3 100644 (file)
--- a/neutron/common/exceptions.py
+++ b/neutron/common/exceptions.py
@@ -18,6 +18,7 @@ Neutron base exception handling.
 """
 
 from oslo_utils import excutils
+import six
 
 
 class NeutronException(Exception):
@@ -40,8 +41,9 @@ class NeutronException(Exception):
                     # at least get the core message out if something happened
                     super(NeutronException, self).__init__(self.message)
 
-    def __unicode__(self):
-        return unicode(self.msg)
+    if six.PY2:
+        def __unicode__(self):
+            return unicode(self.msg)
 
     def use_fatal_exceptions(self):
         return False

diff --git a/neutron/policy.py b/neutron/policy.py
index a2d099f6761f912c217f03d40993a7b789809eba..63a0820b3f1fb37206091c073612a1d75288aac8 100644 (file)
--- a/neutron/policy.py
+++ b/neutron/policy.py
@@ -313,7 +313,7 @@ class OwnerCheck(policy.Check):
                                   f)
         match = self.match % target
         if self.kind in creds:
-            return match == unicode(creds[self.kind])
+            return match == six.text_type(creds[self.kind])
         return False
 
 

diff --git a/neutron/tests/unit/api/v2/test_base.py b/neutron/tests/unit/api/v2/test_base.py
index ab05215e3f95651eccefe801b99259e3ebdec688..ccb4f44b14f2d5249c7199186bb15618932c79f0 100644 (file)
--- a/neutron/tests/unit/api/v2/test_base.py
+++ b/neutron/tests/unit/api/v2/test_base.py
@@ -929,7 +929,9 @@ class JSONV2TestCase(APIv2TestBase, testlib_api.WebTestCase):
         return_value.update(initial_input['port'])
 
         instance = self.plugin.return_value
-        instance.get_network.return_value = {'tenant_id': unicode(tenant_id)}
+        instance.get_network.return_value = {
+            'tenant_id': six.text_type(tenant_id)
+        }
         instance.get_ports_count.return_value = 1
         instance.create_port.return_value = return_value
         res = self.api.post(_get_path('ports', fmt=self.fmt),

diff --git a/neutron/wsgi.py b/neutron/wsgi.py
index 437e57b0984390a87cbc1831c1551962d06a780a..7adba758e4bed95445dc85df4e7c939650f278be 100644 (file)
--- a/neutron/wsgi.py
+++ b/neutron/wsgi.py
@@ -412,7 +412,7 @@ class JSONDictSerializer(DictSerializer):
 
     def default(self, data):
         def sanitizer(obj):
-            return unicode(obj)
+            return six.text_type(obj)
         return jsonutils.dumps(data, default=sanitizer)