Add strict validation about boolean parameters

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: Iaf3c11b61dc738d267282a6bc1d445a554695178

diff --git a/manifests/agent/notification.pp b/manifests/agent/notification.pp
index ad98e8a1eb173158457aedbccb12642e0ffc1e79..7189062d54e99a5ec6897448551f5d5be01844db 100644 (file)
--- a/manifests/agent/notification.pp
+++ b/manifests/agent/notification.pp
@@ -114,6 +114,12 @@ class ceilometer::agent::notification (
   include ceilometer::deps
   include ceilometer::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+  validate_legacy(Boolean, 'validate_bool', $manage_event_pipeline)
+  validate_legacy(Boolean, 'validate_bool', $manage_pipeline)
+
+
   package { 'ceilometer-notification':
     ensure => $package_ensure,
     name   => $::ceilometer::params::agent_notification_package_name,

diff --git a/manifests/agent/polling.pp b/manifests/agent/polling.pp
index a89cbf2d3c6ebd59c7e2a17f0b0673fdb26d3690..e7b701021667800f846d85011e014fa776c65fa3 100644 (file)
--- a/manifests/agent/polling.pp
+++ b/manifests/agent/polling.pp
@@ -104,6 +104,15 @@ class ceilometer::agent::polling (
   include ceilometer::deps
   include ceilometer::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+  validate_legacy(Boolean, 'validate_bool', $separate_services)
+  validate_legacy(Boolean, 'validate_bool', $manage_user)
+  validate_legacy(Boolean, 'validate_bool', $central_namespace)
+  validate_legacy(Boolean, 'validate_bool', $compute_namespace)
+  validate_legacy(Boolean, 'validate_bool', $ipmi_namespace)
+  validate_legacy(Boolean, 'validate_bool', $manage_polling)
+
   if $central_namespace {
     $central_namespace_name = 'central'
     ceilometer_config {