]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Invalid GlusterFS share format error
authorBharat Kumar Kobagana <bkobagan@redhat.com>
Mon, 17 Nov 2014 05:42:13 +0000 (11:12 +0530)
committerBharat Kumar Kobagana <bkobagan@redhat.com>
Tue, 18 Nov 2014 01:02:26 +0000 (06:32 +0530)
When we provide invalid GlusterFS share format in GlusterFS shares
configuration file (glusterfs_shares_config), it will log a
Warning message in the volume log file, which not easily discover
able while debugging.

So, this patch changing Invalid GlusterFS share Warning message to
Error message.

Change-Id: I24d47dafc56490d40bd81256135f4b13fce5614a

cinder/volume/drivers/remotefs.py

index 4c1850d8ac192eb3469a406072bc42edb39d6f08..2a7e582c0187eab64ee129ab809a28a50290cdac 100644 (file)
@@ -377,8 +377,8 @@ class RemoteFSDriver(driver.VolumeDriver):
             share_opts = share_info[1].strip() if len(share_info) > 1 else None
 
             if not re.match(self.SHARE_FORMAT_REGEX, share_address):
-                LOG.warn(_LW("Share %s ignored due to invalid format. Must be "
-                             "of form address:/export.") % share_address)
+                LOG.error(_LE("Share %s ignored due to invalid format. Must "
+                              "be of form address:/export.") % share_address)
                 continue
 
             self.shares[share_address] = share_opts