]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Mock out time.sleep in storwize unit tests
authorJohn Griffith <john.griffith@solidfire.com>
Mon, 14 Jul 2014 23:10:18 +0000 (17:10 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Mon, 14 Jul 2014 23:12:03 +0000 (17:12 -0600)
The Storwize driver has issues that required them
to add a sleep 1 on init of the driver.

No big deal, but causes unit tests to take a very long
time waiting for the "time.sleep(1)" on every single
unit test that calls init.

This patch just mocks out the time.sleep so we don't have
to do the silly waiting in unit tests.

Change-Id: I10fc3d00252a7e7b90085cb308fb9c6c7e1f5ea7

cinder/tests/test_storwize_svc.py

index 375594a09087994a9bccba6e2f163d74a3f89c4c..6ac732c125d6dd33a8bf1d8fe4c425778d2cad03 100644 (file)
@@ -21,6 +21,7 @@ Tests for the IBM Storwize family and SVC volume driver.
 import mock
 import random
 import re
+import time
 
 from cinder import context
 from cinder import exception
@@ -1455,7 +1456,8 @@ class StorwizeSVCFakeDriver(storwize_svc.StorwizeSVCDriver):
 
 
 class StorwizeSVCDriverTestCase(test.TestCase):
-    def setUp(self):
+    @mock.patch.object(time, 'sleep')
+    def setUp(self, mock_sleep):
         super(StorwizeSVCDriverTestCase, self).setUp()
         self.USESIM = True
         if self.USESIM: