]> review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commitdiff
Allow duplicate $required_packages
authorMatthaus Litteken <matthaus@puppetlabs.com>
Fri, 24 Feb 2012 05:01:20 +0000 (21:01 -0800)
committerMatthaus Litteken <matthaus@puppetlabs.com>
Fri, 24 Feb 2012 05:01:20 +0000 (21:01 -0800)
Previously, if more than one apt::source required the same packages to be
installed it would fail with a duplicate exec resource. This adds the name of
the source resource to the exec and gives the exec a name, moving it to a
command parameter for the exec.

manifests/source.pp

index 0512fa96c9ac48440091843781d617ba9cf25cd9..9f31fe91308bbb911b5013a21227b17e4f0e11db 100644 (file)
@@ -36,8 +36,9 @@ define apt::source(
   }
 
   if $required_packages != false {
-    exec { "${apt::params::provider} -y install ${required_packages}":
-      subscribe => File["${name}.list"],
+    exec { "Required packages: '${required_packages}' for ${name}":
+      command     => "${apt::params::provider} -y install ${required_packages}",
+      subscribe   => File["${name}.list"],
       refreshonly => true,
     }
   }