]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Declare multiattach is True in RBD driver
authorwuyuting <wytdahu@gmail.com>
Tue, 24 Nov 2015 09:01:44 +0000 (17:01 +0800)
committerwuyuting <wytdahu@gmail.com>
Tue, 24 Nov 2015 09:20:14 +0000 (17:20 +0800)
An RBD volume can be attached to multi instances, however,
this feature is not declared in RBD driver. As a result,
if a user create a multi-attached volume using RBD as
backend, they will be failed.

In this commit, we declared multiattach is True in RBD
driver.

Change-Id: I70c2c0528d9c00629f9cf34d79262a5bf4750e34
Closes-Bug: #1519227

cinder/tests/unit/test_rbd.py
cinder/volume/drivers/rbd.py

index f0c5556733d177891089f333ad1702c56f53a009..0cfc129c05706445b5b7074aceb27ab2d8009efb 100644 (file)
@@ -721,7 +721,8 @@ class RBDTestCase(test.TestCase):
             storage_protocol='ceph',
             total_capacity_gb=27,
             free_capacity_gb=26,
-            reserved_percentage=0)
+            reserved_percentage=0,
+            multiattach=True)
 
         actual = self.driver.get_volume_stats(True)
         client.cluster.mon_command.assert_called_once_with(
@@ -746,7 +747,8 @@ class RBDTestCase(test.TestCase):
                         storage_protocol='ceph',
                         total_capacity_gb='unknown',
                         free_capacity_gb='unknown',
-                        reserved_percentage=0)
+                        reserved_percentage=0,
+                        multiattach=True)
 
         actual = self.driver.get_volume_stats(True)
         client.cluster.mon_command.assert_called_once_with(
index 3711c08d9f8afa0662fb53ad7d01be854ef71857..c54aecbe29f0239833fb18836efc397a6c3fe678 100644 (file)
@@ -383,6 +383,7 @@ class RBDDriver(driver.TransferVD, driver.ExtendVD,
             'total_capacity_gb': 'unknown',
             'free_capacity_gb': 'unknown',
             'reserved_percentage': 0,
+            'multiattach': True,
         }
         backend_name = self.configuration.safe_get('volume_backend_name')
         stats['volume_backend_name'] = backend_name or 'RBD'