]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
fix conversion type missing
authorKun Huang <academicgareth@gmail.com>
Thu, 5 Sep 2013 06:20:23 +0000 (14:20 +0800)
committerKun Huang <gareth@unitedstack.com>
Thu, 5 Sep 2013 18:16:13 +0000 (02:16 +0800)
Conversion type is missing in some places which would cause some
unexcepted error. By using 'grep -rn "%(\w\+)\W"', we could find
all cases of '%(variable_a)' and fix them.

Change-Id: I05cbaac73976c70be8428bf5a2d0017ea7059cb3
Closes-Bug: #1221036

.mailmap
neutron/plugins/cisco/db/n1kv_db_v2.py
neutron/plugins/mlnx/agent/eswitch_neutron_agent.py
neutron/plugins/nec/common/ofc_client.py

index 6d3ec76d05f15f99257b98d05faec422e9bf3ad6..7bdd06e5e37dded690bcefbb59e463f1aa2f1d12 100644 (file)
--- a/.mailmap
+++ b/.mailmap
@@ -4,3 +4,4 @@
 lawrancejing <lawrancejing@gmail.com> <liuqing@windawn.com>
 Jiajun Liu <jiajun@unitedstack.com> <iamljj@gmail.com>
 Zhongyue Luo <zhongyue.nah@intel.com> <lzyeval@gmail.com>
+Kun Huang <gareth@unitedstack.com> <academicgareth@gmail.com>
index 6db40fff80fe723ac780ef10ccb0d47c9ce179cd..dbc7d334b75dd9b58a068f818978735f0f23716e 100644 (file)
@@ -991,7 +991,7 @@ def delete_profile_binding(tenant_id, profile_id):
             db_session.delete(binding)
     except c_exc.ProfileTenantBindingNotFound:
         LOG.debug(_("Profile-Tenant binding missing for profile ID "
-                  "%(profile_id)s and tenant ID %(tenant_id)") %
+                  "%(profile_id)s and tenant ID %(tenant_id)s") %
                   {"profile_id": profile_id, "tenant_id": tenant_id})
         return
 
index 637c8f582d4c5ab031c797fe774b7ea196ff1000..e05fac15b93c0e8538311932e24da6076f1240a9 100644 (file)
@@ -134,8 +134,8 @@ class EswitchManager(object):
         elif network_type == constants.TYPE_IB:
             LOG.debug(_("creating IB Network"))
         else:
-            LOG.error(_("Unknown network type %(network_type) "
-                        "for network %(network_id)"),
+            LOG.error(_("Unknown network type %(network_type)s "
+                        "for network %(network_id)s"),
                       {'network_type': network_type,
                        'network_id': network_id})
             return
index 6df8b4f030419c290e1e9204a49b40705ffa2c73..4bc49b42a982bf9235e72ce268ae9f6db2846eae 100644 (file)
@@ -97,7 +97,7 @@ class OFCClient(object):
                 return data
             else:
                 LOG.warning(_("Operation on OFC failed: "
-                              "status=%(status), detail=%(detail)"),
+                              "status=%(status)s, detail=%(detail)s"),
                             {'status': res.status, 'detail': data})
                 params = {'reason': _("Operation on OFC failed"),
                           'status': res.status}