]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix usage of 'default' parameter in 1955efc66455 migration
authorAnn Kamyshnikova <akamyshnikova@mirantis.com>
Fri, 20 Mar 2015 15:30:27 +0000 (18:30 +0300)
committerarmando-migliaccio <armamig@gmail.com>
Fri, 20 Mar 2015 21:42:07 +0000 (14:42 -0700)
'default' is useless in migration, to provide default value in db
should be used server_default instead.

Closes-bug: #1434601

Change-Id: If17b48213e03f4b01db08186c272c67709e147f5

neutron/db/agents_db.py
neutron/db/migration/alembic_migrations/versions/1955efc66455_weight_scheduler.py

index 9b01b746376b27c31edd22d3306ca3e0cbe0d578..c9862d131f4cec66fdfca6f94e5b5b56374f228b 100644 (file)
@@ -89,7 +89,7 @@ class Agent(model_base.BASEV2, models_v2.HasId):
     # configurations: a json dict string, I think 4095 is enough
     configurations = sa.Column(sa.String(4095), nullable=False)
     # load - number of resources hosted by the agent
-    load = sa.Column(sa.Integer, default=0, nullable=False)
+    load = sa.Column(sa.Integer, server_default='0', nullable=False)
 
     @property
     def is_active(self):
index 69a0f3345410c50c76f2e654ce06e342ed50436c..63131efa7ff1c9c71ba0e371325fffd54587e9d9 100644 (file)
@@ -32,7 +32,7 @@ import sqlalchemy as sa
 def upgrade():
     op.add_column('agents',
                   sa.Column('load', sa.Integer(),
-                            default=0, nullable=False))
+                            server_default='0', nullable=False))
 
 
 def downgrade():