]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Refactor 'if false do nothing' logic in l3 scheduler db
authorAssaf Muller <amuller@redhat.com>
Wed, 9 Jul 2014 12:54:10 +0000 (15:54 +0300)
committerAssaf Muller <amuller@redhat.com>
Wed, 9 Jul 2014 12:54:47 +0000 (15:54 +0300)
Change-Id: I67983bb1115857ab11e3269fcbe1b20c85c93dbb

neutron/db/l3_agentschedulers_db.py

index 19969cb6000ae2fd7978a9f8f48564ba4701f4d2..e9a63d28d42d8fec5c64b582f60acd81c9cab717 100644 (file)
@@ -163,9 +163,7 @@ class L3AgentSchedulerDbMixin(l3agentscheduler.L3AgentSchedulerPluginBase,
         query = query.filter(
             RouterL3AgentBinding.l3_agent_id == agent.id)
 
-        if not router_ids:
-            pass
-        else:
+        if router_ids:
             query = query.filter(
                 RouterL3AgentBinding.router_id.in_(router_ids))
         router_ids = [item[0] for item in query]