]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Remove VIF_TYPES constant
authorCedric Brandily <zzelle@gmail.com>
Mon, 17 Aug 2015 22:17:34 +0000 (00:17 +0200)
committerCedric Brandily <zzelle@gmail.com>
Thu, 20 Aug 2015 17:57:03 +0000 (19:57 +0200)
VIF_TYPES[1] lists all vif types including out-of-tree ones BUT was only
used by out-of-tree bigswitch code: dependent change defined VIF_TYPES
in bigswitch repo in order to allow VIF_TYPES removal from neutron code.

[1] in neutron.extensions.portbindings

Closes-Bug: #1486277
Related-Bug: #1486279
Depends-On: I79d0af975bb62a2ccea87eda5cf43f3f064b5078
Change-Id: I39fc344361c21332b947f21f157d4f2a27caad47

doc/source/devref/contribute.rst
neutron/extensions/portbindings.py

index d83de01b03a796d0c1be64431540619b2bfc5c29..30a1e31d587bc2399ab63aa77f21d10126eff8f8 100644 (file)
@@ -520,9 +520,11 @@ the installer to configure this item in the ``[default]`` section. For example::
     interface_driver = networking_foo.agent.linux.interface.FooInterfaceDriver
 
 **ToDo: Interface Driver port bindings.**
-    These are currently defined by the ``VIF_TYPES`` in
-    ``neutron/extensions/portbindings.py``. We could make this config-driven
-    for agents. For Nova, selecting the VIF driver can be done outside of
+    ``VIF_TYPE_*`` constants in ``neutron/extensions/portbindings.py`` should be
+    moved from neutron core to the repositories where their drivers are
+    implemented. We need to provide some config or hook mechanism for VIF types
+    to be registered by external interface drivers. For Nova, selecting the VIF
+    driver can be done outside of
     Neutron (using the new `os-vif python library
     <https://review.openstack.org/193668>`_?). Armando and Akihiro to discuss.
 
index a72033405d3b348867d29fbcc45d88249d8f32b9..25cc4b0d2c90bdb5c6f6bd31bc2112ef74cc1aa2 100644 (file)
@@ -81,12 +81,6 @@ VIF_TYPE_IB_HOSTDEV = 'ib_hostdev'
 VIF_TYPE_HW_VEB = 'hw_veb'
 VIF_TYPE_VROUTER = 'vrouter'
 VIF_TYPE_OTHER = 'other'
-VIF_TYPES = [VIF_TYPE_UNBOUND, VIF_TYPE_BINDING_FAILED, VIF_TYPE_OVS,
-             VIF_TYPE_IVS, VIF_TYPE_BRIDGE, VIF_TYPE_802_QBG,
-             VIF_TYPE_802_QBH, VIF_TYPE_HYPERV, VIF_TYPE_MIDONET,
-             VIF_TYPE_IB_HOSTDEV, VIF_TYPE_HW_VEB,
-             VIF_TYPE_DVS, VIF_TYPE_OTHER, VIF_TYPE_DISTRIBUTED,
-             VIF_TYPE_VROUTER]
 
 VNIC_NORMAL = 'normal'
 VNIC_DIRECT = 'direct'