]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Use list copy for events in nova notifier
authorIhar Hrachyshka <ihrachys@redhat.com>
Tue, 22 Apr 2014 13:26:44 +0000 (15:26 +0200)
committerIhar Hrachyshka <ihrachys@redhat.com>
Fri, 23 May 2014 12:11:52 +0000 (14:11 +0200)
There is no need to call range() and len() and .pop() for such a
simple task as list copy.

Change-Id: I4d25e0887ba0a7a5c7f49d195e90a7d2818caac2

neutron/notifiers/nova.py

index 1237a16b74f94aebc2737190f0d1b54b3bd3be72..482bdce52662e0d096cadf19c52926204d931003 100644 (file)
@@ -211,13 +211,12 @@ class Notifier(object):
         port._notify_event = None
 
     def send_events(self):
-        batched_events = []
-        for event in range(len(self.pending_events)):
-            batched_events.append(self.pending_events.pop())
-
-        if not batched_events:
+        if not self.pending_events:
             return
 
+        batched_events = self.pending_events
+        self.pending_events = []
+
         LOG.debug(_("Sending events: %s"), batched_events)
         try:
             response = self.nclient.server_external_events.create(