]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Disallow updating SG rule direction in RESOURCE_ATTRIBUTE_MAP
authorYAMAMOTO Takashi <yamamoto@midokura.com>
Mon, 30 Nov 2015 09:46:17 +0000 (18:46 +0900)
committerYAMAMOTO Takashi <yamamoto@midokura.com>
Tue, 1 Dec 2015 04:28:52 +0000 (13:28 +0900)
It doesn't make much sense to allow updating only the direction.
I suppose it was a bug in the first place.

Partial-Bug: #1521099
Change-Id: Idfd48c801be3cd34286595f5ca3c9d629a296200

neutron/extensions/securitygroup.py

index 018f704420c561aa1d0081d9b790d9eec257d0af..dcaddabfbddda8273bcba9ed2f0ab16dca0e409a 100644 (file)
@@ -236,7 +236,7 @@ RESOURCE_ATTRIBUTE_MAP = {
                               'is_visible': True, 'required_by_policy': True},
         'remote_group_id': {'allow_post': True, 'allow_put': False,
                             'default': None, 'is_visible': True},
-        'direction': {'allow_post': True, 'allow_put': True,
+        'direction': {'allow_post': True, 'allow_put': False,
                       'is_visible': True,
                       'validate': {'type:values': ['ingress', 'egress']}},
         'protocol': {'allow_post': True, 'allow_put': False,