]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Provided requirements are meant to be immutable
authorJoshua Harlow <harlowja@yahoo-inc.com>
Wed, 11 Feb 2015 22:14:51 +0000 (14:14 -0800)
committerJoshua Harlow <harlowja@yahoo-inc.com>
Wed, 11 Feb 2015 22:14:51 +0000 (14:14 -0800)
Since provided values are not meant to change (and
this statement is useless) we should not try to
perform an update() on the provided values (the update
is a no-op anyway, so might as well get rid of it).

Change-Id: I18699fc64391445436537854a5e3723f4e89e961

cinder/volume/flows/api/create_volume.py

index 017bc87a93b249378499d06ff16e528eec11481b..5ca22f15a935c31316e0b29f5936111b320f706c 100644 (file)
@@ -464,7 +464,6 @@ class EntryCreateTask(flow_utils.CinderTask):
         super(EntryCreateTask, self).__init__(addons=[ACTION],
                                               requires=requires)
         self.db = db
-        self.provides.update()
 
     def execute(self, context, optional_args, **kwargs):
         """Creates a database entry for the given inputs and returns details.