]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Used namedtuple for ReservationInfo
authorSalvatore Orlando <salv.orlando@gmail.com>
Thu, 20 Aug 2015 22:33:27 +0000 (15:33 -0700)
committerSalvatore Orlando <salv.orlando@gmail.com>
Thu, 20 Aug 2015 22:33:46 +0000 (15:33 -0700)
The code already uses a namedtuple for ResourceUsageInfo
and it is a nonsense to not use it for ReservationInfo.

Related-Blueprint: bp/better-quotas

Change-Id: I99666ac865fbdeef2d84353eff49d60b6d87fddc

neutron/db/quota/api.py

index 9657db07959fc1b6843e9a40228483438e96bc06..79913913a6294fddee512e2b4965ab2ad907f965 100644 (file)
@@ -37,31 +37,11 @@ class QuotaUsageInfo(collections.namedtuple(
         return self.reserved + self.used
 
 
-class ReservationInfo(object):
+class ReservationInfo(collections.namedtuple(
+    'ReservationInfo', ['reservation_id', 'tenant_id',
+                        'expiration', 'deltas'])):
     """Information about a resource reservation."""
 
-    def __init__(self, reservation_id, tenant_id, expiration, deltas):
-        self._reservation_id = reservation_id
-        self._tenant_id = tenant_id
-        self._expiration = expiration
-        self._deltas = deltas
-
-    @property
-    def reservation_id(self):
-        return self._reservation_id
-
-    @property
-    def tenant_id(self):
-        return self._tenant_id
-
-    @property
-    def expiration(self):
-        return self._expiration
-
-    @property
-    def deltas(self):
-        return self._deltas
-
 
 def get_quota_usage_by_resource_and_tenant(context, resource, tenant_id,
                                            lock_for_update=False):