Modifed error message to be more clear

diff --git a/lib/puppet/provider/firewall/iptables.rb b/lib/puppet/provider/firewall/iptables.rb
index 280ff32dedf517b47d8e36e320bfdfd1eb09ea88..a70d7af5be9d3818840e2c63940cf25b0b32a2f8 100644 (file)
--- a/lib/puppet/provider/firewall/iptables.rb
+++ b/lib/puppet/provider/firewall/iptables.rb
@@ -877,7 +877,7 @@ Puppet::Type.type(:firewall).provide :iptables, parent: Puppet::Provider::Firewa
     # Insert our new or updated rule in the correct order of named rules, but
     # offset for unnamed rules.
     sorted_rules = rules.reject { |r| r.match(unmanaged_rule_regex) }.sort
-    raise 'Invalid ordering value in resource name. The range 9000-9999 is reserved for unmanaged rules.' if sorted_rules.index(my_rule).nil?
+    raise 'Rule sorting error. Make sure that the title of your rule does not start with 9000-9999, as this range is reserved.' if sorted_rules.index(my_rule).nil?
     sorted_rules.index(my_rule) + 1 + unnamed_offset
   end
 end

diff --git a/spec/acceptance/firewall_spec.rb b/spec/acceptance/firewall_spec.rb
index 46eb7f4b56dca3e56ead6fcc6e49da378322ca80..9e9c4812e380c2bb9857992e6c2faffc6128df3a 100644 (file)
--- a/spec/acceptance/firewall_spec.rb
+++ b/spec/acceptance/firewall_spec.rb
@@ -36,7 +36,7 @@ describe 'firewall basics', docker: true do
       PUPPETCODE
       it 'fails' do
         apply_manifest(pp, expect_failures: true) do |r|
-          expect(r.stderr).to match(%r{Invalid ordering value})
+          expect(r.stderr).to match(%r{Ordering error detected})
         end
       end
     end