]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Removed sleep before 'YES' is sent to confim an operation
authorPradeep Sathasivam <psathasi@brocade.com>
Wed, 8 Apr 2015 07:26:23 +0000 (12:56 +0530)
committerPradeep Sathasivam <psathasi@brocade.com>
Thu, 9 Apr 2015 06:58:34 +0000 (06:58 +0000)
Removed sleep between the time a command is sent
and 'YES' is sent to confim the operation. We have
discussed this internally and have concluded that
the sleep was mistakenly added in the initial coding
from an example of the SSH code. We have done full
functionality testing of the zoning operations on
Brocade switches with the sleep removed and have
found no side effects from the removal

Additionally, no other Brocade management
applications which perform zoning on our switches
require sleep intervals between execution of
commands. We are confident that the sleep is not
necessary and can be removed

Change-Id: I2ac6e50ff3d231b4d404f1a0be29f907e8d20458
Closes-Bug: #1436594

cinder/zonemanager/drivers/brocade/brcd_fc_zone_client_cli.py

index 3eaa2728ba4bf77537f018d21586497221202216..52eeef1cdd1c3272e218653ea33b25b2e9db5b9c 100644 (file)
@@ -441,7 +441,6 @@ class BrcdFCZoneClientCLI(object):
                     attempts -= 1
                     try:
                         stdin, stdout, stderr = ssh.exec_command(command)
-                        greenthread.sleep(random.randint(20, 500) / 100.0)
                         stdin.write("%s\n" % ZoneConstant.YES)
                         channel = stdout.channel
                         exit_status = channel.recv_exit_status()