]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Fix up hacking ignores a bit.
authorJohn Griffith <john.griffith@solidfire.com>
Tue, 14 May 2013 17:14:33 +0000 (11:14 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Tue, 14 May 2013 19:18:16 +0000 (13:18 -0600)
Add more explicit ignores to tox.ini hacking ignores until
we have a chance to fix up the imports and docstring errors
we've been ignoring.  This should give us everything we had
in the past (ie alphabetical import checks).

Also, update run_tests.sh to call flake8 and not the hacking.py
that is no longer there.

Change-Id: I6c82e958002255fd9f527b06bf0a68d148cc681e

run_tests.sh
tox.ini

index 4f115589058653c33b1d52ab70c8990fd3cce375..265d31dd37152ca3889743cef92a039562d6b045 100755 (executable)
@@ -110,12 +110,7 @@ srcfiles+=" setup.py"
 
 function run_pep8 {
   echo "Running PEP8 and HACKING compliance check..."
-  # Just run PEP8 in current environment
-  #
-
-  # Until all these issues get fixed, ignore.
-  ignore='--ignore=N4,E125,E126,E711,E712'
-  ${wrapper} python tools/hacking.py ${ignore} ${srcfiles}
+  flake8 cinder* bin
 }
 
 
diff --git a/tox.ini b/tox.ini
index ac75259b69416733b4a7302ca1a98e07328bd8e4..2e5e1707ccf798cef942656be6ecd9957c086b8c 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -37,6 +37,6 @@ deps = -r{toxinidir}/tools/pip-requires
 commands = bash tools/lintstack.sh
 
 [flake8]
-ignore = E12,E711,E712,H3,H4,F
+ignore = E12,E711,E712,H302,H303,H304,H401,H402,H403,H404,F
 builtins = _
 exclude = .venv,.tox,dist,doc,openstack,*egg