]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
heat cli : Add --disable-rollback option to heat-cfn
authorSteven Hardy <shardy@redhat.com>
Thu, 14 Feb 2013 16:16:09 +0000 (16:16 +0000)
committerSteven Hardy <shardy@redhat.com>
Mon, 18 Feb 2013 20:21:10 +0000 (20:21 +0000)
When rollback is implemented it will default on, like aws
so this option allows stack rollback on create to be disabled

blueprint stack-rollback

Change-Id: I02fcaaa656219b1c65729cecdd473e0a5bd86036

bin/heat-cfn
heat/cfn_client/client.py

index 2ec7d336da319901758165c248c912f3f3ff0b91..c4ec11e4ed649eba7dab8044fa7f92a795e8e4d6 100755 (executable)
@@ -201,6 +201,9 @@ def stack_create(options, arguments):
 
     parameters['TimeoutInMinutes'] = options.timeout
 
+    if options.disable_rollback:
+        parameters['DisableRollback'] = 'True'
+
     templ_param = get_template_param(options)
     if templ_param:
         parameters.update(templ_param)
@@ -495,6 +498,10 @@ def create_options(parser):
     parser.add_option('-P', '--parameters', metavar="parameters", default=None,
                       help="Parameter values used to create the stack.")
 
+    parser.add_option('-D', '--disable-rollback', dest="disable_rollback",
+                      default=False, action="store_true",
+                      help="Disable rollback on failure")
+
 
 def credentials_from_env():
     return dict(username=os.getenv('OS_USERNAME'),
index 49dc3e59f1af5f81c4250020c8c958c969060dcc..df196b47ba18cec80d76f0b3b7795169ae23ac55 100644 (file)
@@ -29,7 +29,7 @@ logger = logging.getLogger(__name__)
 SUPPORTED_PARAMS = ('StackName', 'TemplateBody', 'TemplateUrl',
                     'NotificationARNs', 'Parameters', 'Version',
                     'SignatureVersion', 'Timestamp', 'AWSAccessKeyId',
-                    'Signature', 'TimeoutInMinutes',
+                    'Signature', 'TimeoutInMinutes', 'DisableRollback',
                     'LogicalResourceId', 'PhysicalResourceId', 'NextToken',
                     )