[hardware] readonly_user_password should be secret

... because the parameter accepts a password string.

Change-Id: I362b09f60c22d615ed13c79bbc25f27f3b73feb5
(cherry picked from commit d987257e4ef452653650aa03bab748be7c207b3e)

diff --git a/manifests/init.pp b/manifests/init.pp
index 079b4ab71b7605282db1ef54f9dfb2a5c58eb0bf..c4d514f5524f8386d52c53b72ec87dfc0fa66a7b 100644 (file)
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -395,7 +395,7 @@ will be removed in a future release.')
     'DEFAULT/host'                        : value => $host;
     'publisher/telemetry_secret'          : value => $telemetry_secret, secret => true;
     'hardware/readonly_user_name'         : value => $snmpd_readonly_username;
-    'hardware/readonly_user_password'     : value => $snmpd_readonly_user_password;
+    'hardware/readonly_user_password'     : value => $snmpd_readonly_user_password, secret => true;
   }
 
   oslo::messaging::notifications { 'ceilometer_config':

diff --git a/spec/classes/ceilometer_init_spec.rb b/spec/classes/ceilometer_init_spec.rb
index e51a7a96a82092af9aa07267198f72a901e13d24..1b0834354eceaccf1a7557e12cff5fee61a59a59 100644 (file)
--- a/spec/classes/ceilometer_init_spec.rb
+++ b/spec/classes/ceilometer_init_spec.rb
@@ -119,7 +119,7 @@ describe 'ceilometer' do
 
     it 'configures snmpd auth' do
       is_expected.to contain_ceilometer_config('hardware/readonly_user_name').with_value('<SERVICE DEFAULT>')
-      is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>')
+      is_expected.to contain_ceilometer_config('hardware/readonly_user_password').with_value('<SERVICE DEFAULT>').with_secret(true)
     end
 
     it 'configures cache backend' do