]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
pdksync_heads/master-0-gbf720df pdksync_pdksync_heads/master-0-gbf720df
authorEimhin Laverty <eimhin.laverty@puppet.com>
Mon, 17 Dec 2018 11:30:24 +0000 (11:30 +0000)
committerEimhin Laverty <eimhin.laverty@puppet.com>
Mon, 17 Dec 2018 11:30:24 +0000 (11:30 +0000)
.gitattributes
.pdkignore
.puppet-lint.rc [new file with mode: 0644]
.travis.yml
Rakefile
metadata.json
spec/default_facts.yml
spec/spec_helper.rb

index a241f2ba93ecab20b624b078ab13b7181b830197..9032a014a054849db4e22f22b6536cf92c7edd27 100644 (file)
@@ -1 +1,5 @@
-*.rb linguist-language=Puppet
+*.rb eol=lf
+*.erb eol=lf
+*.pp eol=lf
+*.sh eol=lf
+*.epp eol=lf
index 650022e58e7fcced551fb38f7bfdf73e65cb3e84..b713b3b1f79b287fc7c489e7140f2a55dd89b5ba 100644 (file)
 /convert_report.txt
 /update_report.txt
 .DS_Store
+/appveyor.yml
+/.fixtures.yml
+/Gemfile
+/.gitattributes
+/.gitignore
+/.gitlab-ci.yml
+/.pdkignore
+/Rakefile
+/.rspec
+/.rubocop.yml
+/.travis.yml
+/.yardopts
+/spec/
diff --git a/.puppet-lint.rc b/.puppet-lint.rc
new file mode 100644 (file)
index 0000000..e69de29
index e861e357f3e76aa3ce404e0d16c1c80ad1519cf1..11cc5a5d00079dfe121d37221dff8e2de8839f36 100644 (file)
@@ -1,5 +1,4 @@
 ---
-sudo: false
 dist: trusty
 language: ruby
 cache: bundler
@@ -13,7 +12,7 @@ script:
   - 'bundle exec rake $CHECK'
 bundler_args: --without system_tests
 rvm:
-  - 2.5.0
+  - 2.5.1
 env:
   global:
     - BEAKER_PUPPET_COLLECTION=puppet6 PUPPET_GEM_VERSION="~> 6.0"
@@ -24,7 +23,7 @@ matrix:
       bundler_args: 
       dist: trusty
       env: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_set=docker/centos-7 BEAKER_TESTMODE=apply
-      rvm: 2.5.0
+      rvm: 2.5.1
       script: bundle exec rake beaker
       services: docker
       sudo: required
@@ -32,7 +31,7 @@ matrix:
       bundler_args: 
       dist: trusty
       env: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_set=docker/ubuntu-14.04 BEAKER_TESTMODE=apply
-      rvm: 2.5.0
+      rvm: 2.5.1
       script: bundle exec rake beaker
       services: docker
       sudo: required
index 204fb18cdc93921bd5fd42edf660b53e874f7ef8..a6b14c56414df983a540588e2a4348256a9db186 100644 (file)
--- a/Rakefile
+++ b/Rakefile
@@ -2,6 +2,7 @@ require 'puppetlabs_spec_helper/rake_tasks'
 require 'puppet-syntax/tasks/puppet-syntax'
 require 'puppet_blacksmith/rake_tasks' if Bundler.rubygems.find_name('puppet-blacksmith').any?
 require 'github_changelog_generator/task' if Bundler.rubygems.find_name('github_changelog_generator').any?
+require 'puppet-strings/tasks' if Bundler.rubygems.find_name('puppet-strings').any?
 
 def changelog_user
   return unless Rake.application.top_level_tasks.include? "changelog"
index 47e243518faf9690809949e791f357a6f60c2354..e12cb50578756ed89d706c7927ee89215cad437c 100644 (file)
@@ -75,6 +75,6 @@
     }
   ],
   "template-url": "https://github.com/puppetlabs/pdk-templates",
-  "template-ref": "heads/master-0-gabccfb1",
-  "pdk-version": "1.7.0"
-}
+  "template-ref": "heads/master-0-gbf720df",
+  "pdk-version": "1.8.0"
+}
\ No newline at end of file
index e10d991db2309d55e9b3ff432aeb50399b90fd67..ea1e4808e3a67f50ea6d64d23a0eb8b3fd25437f 100644 (file)
@@ -2,7 +2,6 @@
 #
 # Facts specified here will override the values provided by rspec-puppet-facts.
 ---
-concat_basedir: ""
 ipaddress: "172.16.254.254"
 is_pe: false
 macaddress: "AA:AA:AA:AA:AA:AA"
index a7281d530037b7c417fa03ab50dad09176ff2b1d..35654b3d2cab1789591caaaa414631fd7ded9376 100644 (file)
@@ -36,8 +36,8 @@ end
 
 def ensure_module_defined(module_name)
   module_name.split('::').reduce(Object) do |last_module, next_module|
-    last_module.const_set(next_module, Module.new) unless last_module.const_defined?(next_module)
-    last_module.const_get(next_module)
+    last_module.const_set(next_module, Module.new) unless last_module.const_defined?(next_module, false)
+    last_module.const_get(next_module, false)
   end
 end