]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
netaddr<=0.7.10 raises ValueError instead of AddrFormatError
authorAaron Rosen <aaronorosen@gmail.com>
Wed, 16 Apr 2014 18:31:25 +0000 (11:31 -0700)
committerGerrit Code Review <review@openstack.org>
Fri, 18 Apr 2014 04:07:07 +0000 (04:07 +0000)
This patch ensures that ValueError is also caught in addition to
AddrFormatError as in netaddr>=0.7.11 AddrFormatError is raised and
in netaddr<=0.7.10 ValueError is raised.

Change-Id: I595c90e42129a2d365f3860e3042e826bd031365
Closes-bug: #1308675

neutron/extensions/securitygroup.py

index 2e65aed2c6b2d788441f19cc452992a55cba04ec..1450b6944890b0c489340dc6f82b80b06fcec0da 100644 (file)
@@ -167,7 +167,7 @@ def convert_ip_prefix_to_cidr(ip_prefix):
     try:
         cidr = netaddr.IPNetwork(ip_prefix)
         return str(cidr)
-    except (TypeError, netaddr.AddrFormatError):
+    except (ValueError, TypeError, netaddr.AddrFormatError):
         raise qexception.InvalidCIDR(input=ip_prefix)