Dell SC API change fails snapshot creation

The Dell Storage Center driver is failing snapshot creation on
later versions of the Dell REST API.

The doNotExpire option was removed in API 15.3.1.110.  We were
setting this so that the replays are not expired and removed when
Cinder expects them to still be there.  This has been replaced by
setting expiretime to 0.  We were doing this already so the fix
was to simply remove doNotExpire from the REST request payload.

This will fail on every future release of the Dell Storage Center
so this is a critical fix.

Closes-Bug 1428259

Change-Id: I51fbf599e29e30793cdd1e6014e876d749732fd3

diff --git a/cinder/volume/drivers/dell/dell_storagecenter_api.py b/cinder/volume/drivers/dell/dell_storagecenter_api.py
index 38fb26cca20470de7e0a43433e819eb45584508f..228b3c0a818a8fb14a120a522b74335afadc0246 100644 (file)
--- a/cinder/volume/drivers/dell/dell_storagecenter_api.py
+++ b/cinder/volume/drivers/dell/dell_storagecenter_api.py
@@ -941,8 +941,6 @@ class StorageCenterApi(object):
             payload = {}
             payload['description'] = replayid
             payload['expireTime'] = expire
-            if expire == 0:
-                payload['doNotExpire'] = True
             r = self.client.post('StorageCenter/ScVolume/%s/CreateReplay'
                                  % self._get_id(scvolume),
                                  payload)