]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
ensure all enums in loadbalancer models have names
authorMark McClain <mark.mcclain@dreamhost.com>
Mon, 14 Jan 2013 20:31:37 +0000 (15:31 -0500)
committerMark McClain <mark.mcclain@dreamhost.com>
Mon, 14 Jan 2013 20:31:37 +0000 (15:31 -0500)
fixes bug 1099565

Postgres requires that enums types have names.  This fix adds the name
parameter to the Enum declaration.

Change-Id: Ica67c6cf0b8959761f3022552c1c6a807a4ced82

quantum/db/loadbalancer/loadbalancer_db.py

index 41a7be83087b7b77104a535c4448c3d54447c43f..db12628685cee7933948c4863e8970844eeebd8b 100644 (file)
@@ -45,7 +45,7 @@ class SessionPersistence(model_base.BASEV2):
     type = sa.Column(sa.Enum("SOURCE_IP",
                              "HTTP_COOKIE",
                              "APP_COOKIE",
-                             name="type"),
+                             name="sesssionpersistences_type"),
                      nullable=False)
     cookie_name = sa.Column(sa.String(1024))
 
@@ -67,7 +67,7 @@ class Vip(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):
     subnet_id = sa.Column(sa.String(36), nullable=False)
     address = sa.Column(sa.String(64))
     port = sa.Column(sa.Integer, nullable=False)
-    protocol = sa.Column(sa.Enum("HTTP", "HTTPS", name="protocol"),
+    protocol = sa.Column(sa.Enum("HTTP", "HTTPS", name="vip_protocol"),
                          nullable=False)
     pool_id = sa.Column(sa.String(36), nullable=False)
     session_persistence = orm.relationship(SessionPersistence,
@@ -99,7 +99,8 @@ class Pool(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):
     protocol = sa.Column(sa.String(64), nullable=False)
     lb_method = sa.Column(sa.Enum("ROUND_ROBIN",
                                   "LEAST_CONNECTIONS",
-                                  "SOURCE_IP"),
+                                  "SOURCE_IP",
+                                  name="pools_lb_method"),
                           nullable=False)
     status = sa.Column(sa.String(16), nullable=False)
     admin_state_up = sa.Column(sa.Boolean(), nullable=False)
@@ -115,7 +116,8 @@ class Pool(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):
 
 class HealthMonitor(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):
     """Represents a v2 quantum loadbalancer healthmonitor."""
-    type = sa.Column(sa.Enum("PING", "TCP", "HTTP", "HTTPS", name="type"),
+    type = sa.Column(sa.Enum("PING", "TCP", "HTTP", "HTTPS",
+                             name="healthmontiors_type"),
                      nullable=False)
     delay = sa.Column(sa.Integer, nullable=False)
     timeout = sa.Column(sa.Integer, nullable=False)