]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Fix _migrate_up in test_migrations
authorChris Yeoh <cyeoh@au1.ibm.com>
Wed, 13 Mar 2013 01:53:53 +0000 (12:23 +1030)
committerChris Yeoh <cyeoh@au1.ibm.com>
Wed, 13 Mar 2013 01:56:11 +0000 (12:26 +1030)
_migrate_up should always actually do a db upgrade whether or
not it is being tested with data or not

Change-Id: I28cbab36a5227903ff40a3243492b34d4b82a223

cinder/tests/test_migrations.py

index 847eb4bf9ff9e4ccef585118ad0607082982c401..47b1050c512cf0b9139b29dd62b33b4e5530a4ee 100644 (file)
@@ -353,13 +353,13 @@ class TestMigrations(test.TestCase):
                 if prerun:
                     data = prerun(engine)
 
-                migration_api.upgrade(engine,
-                                      TestMigrations.REPOSITORY,
-                                      version)
-                self.assertEqual(
-                    version,
-                    migration_api.db_version(engine,
-                                             TestMigrations.REPOSITORY))
+            migration_api.upgrade(engine,
+                                  TestMigrations.REPOSITORY,
+                                  version)
+            self.assertEqual(
+                version,
+                migration_api.db_version(engine,
+                                         TestMigrations.REPOSITORY))
 
             if with_data:
                 check = getattr(self, "_check_%3.3d" % version, None)