]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
(maint) Replace version comparisons unnafected by MODULES-4528 to use versioncmp MODULES-4528
authorWilson McCoubrey <wilson@puppet.com>
Thu, 16 Mar 2017 15:50:04 +0000 (15:50 +0000)
committerWilson McCoubrey <wilson@puppet.com>
Thu, 16 Mar 2017 15:50:04 +0000 (15:50 +0000)
For sake of consistency

spec/unit/puppet/provider/ip6tables_spec.rb
spec/unit/puppet/provider/iptables_chain_spec.rb
spec/unit/puppet/provider/iptables_spec.rb

index 058c90bcac637a5a93a28f955505def8aa91c518..6e8b8660dd5bb2736fd447d3aee7c482b88a142d 100644 (file)
@@ -1,7 +1,7 @@
 #!/usr/bin/env rspec
 
 require 'spec_helper'
-if Puppet.version < '3.4.0'
+if Puppet::Util::Package.versioncmp(Puppet.version, '3.4.0') < 0
   require 'puppet/provider/confine/exists'
 else
   require 'puppet/confine/exists'
index d8eade23692b9e54fc216381e6c71297c46a3e05..78db5557a5dc30fc585790d0e80fb493e1e84e0f 100755 (executable)
@@ -1,14 +1,14 @@
 #!/usr/bin/env rspec
 
 require 'spec_helper'
-if Puppet.version < '3.4.0'
+if Puppet::Util::Package.versioncmp(Puppet.version, '3.4.0') < 0
   require 'puppet/provider/confine/exists'
 else
   require 'puppet/confine/exists'
 end
 
 describe 'iptables chain provider detection' do
-  if Puppet.version < '3.4.0'
+  if Puppet::Util::Package.versioncmp(Puppet.version, '3.4.0') < 0
     let(:exists) {
       Puppet::Provider::Confine::Exists
     }
index f9316d96abec22b834fcb2de1cc72ec90a5ec7da..d5e008288809bae4ee5b10653befda7779dc2309 100644 (file)
@@ -1,14 +1,14 @@
 #!/usr/bin/env rspec
 
 require 'spec_helper'
-if Puppet.version < '3.4.0'
+if Puppet::Util::Package.versioncmp(Puppet.version, '3.4.0') < 0
   require 'puppet/provider/confine/exists'
 else
   require 'puppet/confine/exists'
 end
 
 describe 'iptables provider detection' do
-  if Puppet.version < '3.4.0'
+  if Puppet::Util::Package.versioncmp(Puppet.version, '3.4.0') < 0
     let(:exists) {
       Puppet::Provider::Confine::Exists
     }