Unit test fixes

diff --git a/spec/unit/classes/firewall_linux_redhat_spec.rb b/spec/unit/classes/firewall_linux_redhat_spec.rb
index 8feecf4a7cc7fe8fb2ac27e69e22c493ff336909..036488a743cd68e75fd783dbc8fbcdc6e4b70b2d 100644 (file)
--- a/spec/unit/classes/firewall_linux_redhat_spec.rb
+++ b/spec/unit/classes/firewall_linux_redhat_spec.rb
@@ -1,5 +1,27 @@
 require 'spec_helper'
 
+RSpec.shared_examples "ensures iptables service" do
+  context 'default' do
+    it { should contain_service('iptables').with(
+      :ensure => 'running',
+      :enable => 'true'
+    )}
+  end
+      
+  context 'ensure => stopped' do
+    let(:params) {{ :ensure => 'stopped' }}
+    it { should contain_service('iptables').with(
+      :ensure => 'stopped'
+    )}
+  end
+  context 'enable => false' do
+    let(:params) {{ :enable => 'false' }}
+    it { should contain_service('iptables').with(
+      :enable => 'false'
+    )}
+  end
+end
+
 describe 'firewall::linux::redhat', :type => :class do
   %w{RedHat CentOS Fedora}.each do |os|
     oldreleases = (os == 'Fedora' ? ['14'] : ['6.5'])
@@ -15,6 +37,8 @@ describe 'firewall::linux::redhat', :type => :class do
 
         it { should_not contain_service('firewalld') }
         it { should_not contain_package('iptables-services') }
+        
+        it_behaves_like "ensures iptables service"
       end
     end
 
@@ -36,27 +60,8 @@ describe 'firewall::linux::redhat', :type => :class do
           :ensure => 'present',
           :before => 'Service[iptables]'
         )}
-      end
-    end
 
-    describe 'ensure' do
-      context 'default' do
-        it { should contain_service('iptables').with(
-          :ensure => 'running',
-          :enable => 'true'
-        )}
-      end
-      context 'ensure => stopped' do
-        let(:params) {{ :ensure => 'stopped' }}
-        it { should contain_service('iptables').with(
-          :ensure => 'stopped'
-        )}
-      end
-      context 'enable => false' do
-        let(:params) {{ :enable => 'false' }}
-        it { should contain_service('iptables').with(
-          :enable => 'false'
-        )}
+        it_behaves_like "ensures iptables service"
       end
     end
   end