Fix overwrite of params in SF image cache update

In the update cache volume routine of the SolidFire driver
we're unintentionally re-initializing the params variable
when assigning volID as opposed to just appending another key
to it.

This patch fixes that.

Change-Id: I213776ee6aef6e5dee2807c19b7eea05af23d6c0
Closes-Bug: #1454425

diff --git a/cinder/volume/drivers/solidfire.py b/cinder/volume/drivers/solidfire.py
index 9f6e2fd15f1a7f85fccf770d6f3593298235ac01..3accf8866972bbf205d49eb7034b54379aa19825 100644 (file)
--- a/cinder/volume/drivers/solidfire.py
+++ b/cinder/volume/drivers/solidfire.py
@@ -608,7 +608,7 @@ class SolidFireDriver(san.SanISCSIDriver):
         else:
             # Bummer, it's been updated, delete it
             params = {'accountID': sfaccount['accountID']}
-            params = {'volumeID': sf_vol['volumeID']}
+            params['volumeID'] = sf_vol['volumeID']
             data = self._issue_api_request('DeleteVolume', params)
             if 'result' not in data:
                 msg = _("Failed to delete SolidFire Image-Volume: %s") % data