# ppa.pp
define apt::ppa(
- $ensure = 'present',
- $release = $::lsbdistcodename,
- $options = $::apt::ppa_options,
+ $ensure = 'present',
+ $release = $::lsbdistcodename,
+ $options = $::apt::ppa_options,
+ $package_name = $::apt::ppa_package,
+ $package_manage = false,
) {
-
if ! $release {
fail('lsbdistcodename fact not available: release parameter required')
}
$sources_list_d_filename = "${filename_without_ppa}-${release}.list"
if $ensure == 'present' {
- $package = $::lsbdistrelease ? {
- /^[1-9]\..*|1[01]\..*|12.04$/ => 'python-software-properties',
- default => 'software-properties-common',
- }
+ if $package_manage {
+ package { $package_name: }
- if ! defined(Package[$package]) {
- package { $package: }
+ $_require = [File['sources.list.d'], Package[$package_name]]
+ } else {
+ $_require = File['sources.list.d']
}
- if defined(Class[apt]) {
- $proxy_host = $apt::proxy_host
- $proxy_port = $apt::proxy_port
- case $proxy_host {
- false, '', undef: {
- $proxy_env = []
- }
- default: {
- $proxy_env = ["http_proxy=http://${proxy_host}:${proxy_port}", "https_proxy=http://${proxy_host}:${proxy_port}"]
- }
- }
- } else {
- $proxy_env = []
+ case $::apt::proxy_host {
+ false, '', undef: {
+ $_proxy_env = []
+ }
+ default: {
+ $_proxy_env = ["http_proxy=http://${::apt::proxy_host}:${::apt::proxy_port}", "https_proxy=http://${::apt::proxy_host}:${::apt::proxy_port}"]
+ }
}
+
exec { "add-apt-repository-${name}":
- environment => $proxy_env,
- command => "/usr/bin/add-apt-repository ${options} ${name}",
- unless => "/usr/bin/test -s ${::apt::sources_list_d}/${sources_list_d_filename}",
- user => 'root',
- logoutput => 'on_failure',
- notify => Exec['apt_update'],
- require => [
- File['sources.list.d'],
- Package[$package],
- ],
+ environment => $_proxy_env,
+ command => "/usr/bin/add-apt-repository ${options} ${name}",
+ unless => "/usr/bin/test -s ${::apt::sources_list_d}/${sources_list_d_filename}",
+ user => 'root',
+ logoutput => 'on_failure',
+ notify => Exec['apt_update'],
+ require => $_require,
}
file { "${::apt::sources_list_d}/${sources_list_d_filename}":
- ensure => file,
- require => Exec["add-apt-repository-${name}"],
+ ensure => file,
+ require => Exec["add-apt-repository-${name}"],
}
}
else {
-
file { "${::apt::sources_list_d}/${sources_list_d_filename}":
- ensure => 'absent',
- notify => Exec['apt_update'],
+ ensure => 'absent',
+ notify => Exec['apt_update'],
}
}
end
let(:title) { 'ppa:needs/such.substitution/wow' }
- it { is_expected.to contain_package('python-software-properties') }
+ it { is_expected.to_not contain_package('python-software-properties') }
it { is_expected.to contain_exec('add-apt-repository-ppa:needs/such.substitution/wow').that_notifies('Exec[apt_update]').with({
'environment' => [],
'command' => '/usr/bin/add-apt-repository -y ppa:needs/such.substitution/wow',
'logoutput' => 'on_failure',
})
}
-
- it { is_expected.to contain_file('/etc/apt/sources.list.d/needs-such_substitution-wow-natty.list').that_requires('Exec[add-apt-repository-ppa:needs/such.substitution/wow]').with({
- 'ensure' => 'file',
- })
- }
end
describe 'apt included, no proxy' do
let :params do
{
'options' => '',
+ 'package_manage' => true,
}
end
let(:title) { 'ppa:foo' }
'logoutput' => 'on_failure',
})
}
-
- it { is_expected.to contain_file('/etc/apt/sources.list.d/foo-trusty.list').that_requires('Exec[add-apt-repository-ppa:foo]').with({
- 'ensure' => 'file',
- })
- }
end
describe 'ensure absent' do