]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Remove redundant logging statements from RootWrapDaemonHelper
authorRyan Moats <rmoats@us.ibm.com>
Mon, 24 Aug 2015 13:49:09 +0000 (08:49 -0500)
committerRyan Moats <rmoats@us.ibm.com>
Mon, 24 Aug 2015 13:50:02 +0000 (08:50 -0500)
create_process and execute_rootwrap_daemon both current log
the command they are about to run.  Remove these statements as
redundant (the log message showing the command's result includes
the command itself)

Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Change-Id: I8bdea7212f8a32a3b6b0b47c5b824ac1c561d83f

neutron/agent/linux/utils.py

index 95c47a0607bc0080b6c0efd431366889250df66a..67be8ad495807f11b56943cc76b20089ceba13e5 100644 (file)
@@ -83,7 +83,6 @@ def create_process(cmd, run_as_root=False, addl_env=None):
     cmd = list(map(str, addl_env_args(addl_env) + cmd))
     if run_as_root:
         cmd = shlex.split(config.get_root_helper(cfg.CONF)) + cmd
-    LOG.debug("Running command: %s", cmd)
     obj = utils.subprocess_popen(cmd, shell=False,
                                  stdin=subprocess.PIPE,
                                  stdout=subprocess.PIPE,
@@ -99,7 +98,6 @@ def execute_rootwrap_daemon(cmd, process_input, addl_env):
     # In practice, no neutron code should be trying to execute something that
     # would throw those errors, and if it does it should be fixed as opposed to
     # just logging the execution error.
-    LOG.debug("Running command (rootwrap daemon): %s", cmd)
     client = RootwrapDaemonHelper.get_client()
     return client.execute(cmd, process_input)