Cleaned up some TODO comments for feature/qos that do not apply anymore

1. Removed comment to add tests for invalid input for attach/detach
methods for QosPolicy. Those tests are already implemented in the test
class, so the TODO became obsolete.

2. Removed TODO to use a constant for rule 'type' field. There is no
'type' field in rules anymore, so it does not apply any more.

Change-Id: I205cbc2d9a2eeee1a0a9fb5794efc063de6f326d
Partially-Implements: blueprint quantum-qos-api

diff --git a/neutron/tests/tempest/services/network/json/network_client.py b/neutron/tests/tempest/services/network/json/network_client.py
index c01c83c706aa6df08d75e88fd384ab35be0b5185..daf563f21bede5c265f3470112ca58d74ffdb92f 100644 (file)
--- a/neutron/tests/tempest/services/network/json/network_client.py
+++ b/neutron/tests/tempest/services/network/json/network_client.py
@@ -656,7 +656,6 @@ class NetworkClientJSON(service_client.ServiceClient):
     def create_bandwidth_limit_rule(self, policy_id, max_kbps, max_burst_kbps):
         uri = '%s/qos/policies/%s/bandwidth_limit_rules' % (
             self.uri_prefix, policy_id)
-        #TODO(QoS): 'bandwidth_limit' should not be a magic string.
         post_data = self.serialize(
             {'bandwidth_limit_rule': {
                 'max_kbps': max_kbps,

diff --git a/neutron/tests/unit/objects/qos/test_policy.py b/neutron/tests/unit/objects/qos/test_policy.py
index 20807c904363c58ef47584dc2e8330843c9652fa..3eede4f5fe0a7a366194614e5cef5d1c29e29c39 100644 (file)
--- a/neutron/tests/unit/objects/qos/test_policy.py
+++ b/neutron/tests/unit/objects/qos/test_policy.py
@@ -124,7 +124,6 @@ class QosPolicyDbObjectTestCase(test_base.BaseDbObjectTestCase,
                                            'device_id': 'fake_device',
                                            'device_owner': 'fake_owner'})
 
-    #TODO(QoS): give a thought on checking detach/attach for invalid values.
     def test_attach_network_get_network_policy(self):
 
         obj = self._create_test_policy()