]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
heat engine : remove KeystoneClient get_user_by_name
authorSteven Hardy <shardy@redhat.com>
Mon, 3 Dec 2012 11:06:56 +0000 (11:06 +0000)
committerSteven Hardy <shardy@redhat.com>
Mon, 3 Dec 2012 12:08:15 +0000 (12:08 +0000)
Remove get_user_by_name as it's no longer used, and we want to
avoid this style of name->id lookup because it requires keystone
admin role.

Change-Id: I234a235864ac7537df09cae2f07d99ed9d53acd2
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat/common/heat_keystoneclient.py
heat/tests/fakes.py

index 0db7ffbd8d824c7f0d78bdc12b2858274bccabef..02aaa3bb04f63abd440975cea65cb5fc4c2def92 100644 (file)
@@ -86,16 +86,6 @@ class KeystoneClient(object):
 
         return user.id
 
-    def get_user_by_name(self, username):
-        """
-        Return the ID for the specified username
-        """
-        users = self.client.users.list(tenant_id=self.context.tenant_id)
-        for u in users:
-            if u.name == username:
-                return u.id
-        return None
-
     def delete_stack_user(self, user_id):
 
         user = self.client.users.get(user_id)
index 89be718d0689446b3e9872fd6f4f65a2bdd9ab40..38dc65799d3a03928b397de2d485627f444f5879 100644 (file)
@@ -102,10 +102,6 @@ class FakeKeystoneClient():
     def delete_stack_user(self, user_id):
         self.user_id = None
 
-    def get_user_by_name(self, username):
-        if username == self.username:
-            return self.user_id
-
     def get_ec2_keypair(self, user_id):
         if user_id == self.user_id:
             if not self.creds: