]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Remove local variables from IPDevice.exists
authorBrian Haley <brian.haley@hpe.com>
Fri, 2 Oct 2015 03:35:24 +0000 (23:35 -0400)
committerBrian Haley <brian.haley@hpe.com>
Fri, 2 Oct 2015 03:35:24 +0000 (23:35 -0400)
As suggested by Carl, code is functionally the same.

Change-Id: I80fe8dc8f6f379c7b9561049075fdf718943246b

neutron/agent/linux/ip_lib.py

index 59354b3c72186df1557cd991d8e5125f21820fe0..17600812de9eb121b062fd4f4c059d7869cb8e9e 100644 (file)
@@ -236,16 +236,12 @@ class IPDevice(SubProcessBase):
         orig_log_fail_as_error = self.get_log_fail_as_error()
         self.set_log_fail_as_error(False)
         try:
-            address = self.link.address
+            return bool(self.link.address)
         except RuntimeError:
-            exists = False
-        else:
-            exists = bool(address)
+            return False
         finally:
             self.set_log_fail_as_error(orig_log_fail_as_error)
 
-        return exists
-
     def delete_addr_and_conntrack_state(self, cidr):
         """Delete an address along with its conntrack state