]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Remove INACTIVE status from FWaaS
authorXuhan Peng <xuhanp@cn.ibm.com>
Thu, 14 Aug 2014 03:21:53 +0000 (11:21 +0800)
committerXuhan Peng <xuhanp@cn.ibm.com>
Thu, 14 Aug 2014 03:21:53 +0000 (11:21 +0800)
DOWN status is introduced to replace INACTIVE status. There is one
place in FWaaS code which still checks INACTIVE status.

This commit removes INACTIVE status from FWaaS.

Change-Id: I896c81a6229978a46f8a88a31936920a1036f142
Partial-Bug: #1286048

neutron/services/firewall/fwaas_plugin.py

index 27a54393064490f8f6656be1ee059f952eec6140..051ba1f60875525ca7f59bb44ecba048adbbbe61 100644 (file)
@@ -52,9 +52,7 @@ class FirewallCallbacks(n_rpc.RpcCallback):
                             "not changing to %(status)s"),
                           {'fw_id': firewall_id, 'status': status})
                 return False
-            #TODO(xuhanp): Remove INACTIVE status and use DOWN to
-            # be consistent with other network resources
-            if status in (const.ACTIVE, const.INACTIVE, const.DOWN):
+            if status in (const.ACTIVE, const.DOWN):
                 fw_db.status = status
                 return True
             else: