]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Code Review / openstack-build / cinder-build.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 407d9e5)
CoraidDriver: do not call login from __init__
authorJean-Baptiste RANSY <jean-baptiste.ransy@alyseo.com>
Thu, 21 Mar 2013 11:08:53 +0000 (12:08 +0100)
committerjohn-griffith <john.griffith@solidfire.com>
Sat, 23 Mar 2013 21:36:49 +0000 (15:36 -0600)
We should not call _login from the driver's __init__.
If the ESM is down, the constructor will fail.

- self._login()

Fixes bug 1157500

Change-Id: Ie57fbb6d3704d270a81cd9eb056d7988989da1f8
(cherry picked from commit 28102bc54ac2793ea17f47c81f6812bb84615834)

cinder/volume/drivers/coraid.py patch | blob | history

diff --git a/cinder/volume/drivers/coraid.py b/cinder/volume/drivers/coraid.py
index 8471a0b66ddb257ba08d3392800f61ab814e958b..9ee55a82b4222de78274533cf3f24797b8ad531c 100644 (file)
--- a/cinder/volume/drivers/coraid.py
+++ b/cinder/volume/drivers/coraid.py
@@ -83,7 +83,6 @@ class CoraidRESTClient(object):
         self.urlOpener = urllib2.build_opener(
             urllib2.HTTPCookieProcessor(self.cookiejar))
         LOG.debug(_('Running with CoraidDriver for ESM EtherCLoud'))
-        self._login()
 
     def _login(self):
         """Login and Session Handler."""