]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Validate local_ip for OVS agent is actual ip address
authorJakub Libosvar <libosvar@redhat.com>
Tue, 29 Jul 2014 08:50:12 +0000 (10:50 +0200)
committerJakub Libosvar <libosvar@redhat.com>
Wed, 22 Oct 2014 07:18:35 +0000 (07:18 +0000)
tunnel_sync() writes this value into ovsdb and value is not validated. In
case non-ip value is written into ovsdb row must be deleted manually.

Change-Id: I57eee81e6821eb2cb26b3d07a39bc94b81243570
Closes-bug: #1284684

neutron/plugins/openvswitch/common/config.py

index d9e0454839c7934a77713967de81ed7d7404450b..2392372ef8a2373777480a833aba0b04f977bd13 100644 (file)
@@ -37,8 +37,8 @@ ovs_opts = [
     cfg.StrOpt('tun_peer_patch_port', default='patch-int',
                help=_("Peer patch port in tunnel bridge for integration "
                       "bridge.")),
-    cfg.StrOpt('local_ip', default='',
-               help=_("Local IP address of GRE tunnel endpoints.")),
+    cfg.IPOpt('local_ip', version=4,
+              help=_("Local IP address of tunnel endpoint.")),
     cfg.ListOpt('bridge_mappings',
                 default=DEFAULT_BRIDGE_MAPPINGS,
                 help=_("List of <physical_network>:<bridge>. "