]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Add user-supplied arguments in log_handler
authorShuangtai Tian <shuangtai.tian@intel.com>
Wed, 26 Feb 2014 11:11:38 +0000 (19:11 +0800)
committerThomas Goirand <thomas@goirand.fr>
Thu, 13 Mar 2014 07:20:33 +0000 (15:20 +0800)
Sync from Oslo, change-id: I91289cc4a60f5dab89bca852e6f52b4b83831e47

When using PublishErrorsHandler, it will missing user-supplied
arguments. For example, do LOG.info("blabla %s", "foo"), the
payload only contains "blabla %s", but we expect it like "blabla foo".

Change-Id: I9e5515da31a04b82d49e406bc6b246f940fb73fc

neutron/openstack/common/log_handler.py

index 8156f37e196ceec34fff1f429aeee0a803f2f141..4da3ad36899d1370b85b4f3e2d5173606fc14679 100644 (file)
@@ -11,6 +11,7 @@
 #    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 #    License for the specific language governing permissions and limitations
 #    under the License.
+
 import logging
 
 from oslo.config import cfg
@@ -26,4 +27,4 @@ class PublishErrorsHandler(logging.Handler):
         notifier.api.notify(None, 'error.publisher',
                             'error_notification',
                             notifier.api.ERROR,
-                            dict(error=record.msg))
+                            dict(error=record.getMessage()))