]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
Tolerate missing user on signal responder delete
authorSteve Baker <sbaker@redhat.com>
Tue, 13 Aug 2013 23:15:38 +0000 (11:15 +1200)
committerSteve Baker <sbaker@redhat.com>
Tue, 13 Aug 2013 23:15:38 +0000 (11:15 +1200)
SignalResponder delete fails if the created user
has already been deleted.

This change catches the 404 as for the User resource.

Change-Id: I55034469d10f2742296f0415fe26272d3683530d
Closes-bug: #1211633

heat/engine/signal_responder.py

index 2bf08a18fa1948d674477789e4e7b3dd59468669..e51222c6f0ef6ed8dde459b9f27c7c8e31c9829e 100644 (file)
@@ -21,6 +21,7 @@ from oslo.config import cfg
 from keystoneclient.contrib.ec2 import utils as ec2_utils
 
 from heat.common import exception
+from heat.engine import clients
 from heat.engine import resource
 
 from heat.openstack.common import log
@@ -51,7 +52,10 @@ class SignalResponder(resource.Resource):
     def handle_delete(self):
         if self.resource_id is None:
             return
-        self.keystone().delete_stack_user(self.resource_id)
+        try:
+            self.keystone().delete_stack_user(self.resource_id)
+        except clients.hkc.kc.exceptions.NotFound:
+            pass
 
     def _get_signed_url(self, signal_type=SIGNAL):
         """Create properly formatted and pre-signed URL.