]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
getLogger should be called after logging is configured
authorDavanum Srinivas <dims@linux.vnet.ibm.com>
Wed, 27 Mar 2013 19:17:44 +0000 (15:17 -0400)
committerChuck Short <chuck.short@canonical.com>
Thu, 11 Apr 2013 17:12:46 +0000 (12:12 -0500)
logging needs to be setup properly before we try to log
something. Fixed one spot from logging->LOG

Fixes LP# 1161038

Change-Id: I87743cff9062e47c1d5e989c2c0c05c3921b65c7
(cherry picked from commit 3a106f7e67e4b7f7c446058b98c33f8c71ca2868)

bin/cinder-all

index e3c74eff8c412e41b5ddaf4a185f06d550a46bfd..e384e89c6ab0771aef49eab84e10cde04051ad4e 100755 (executable)
@@ -46,18 +46,18 @@ from cinder import service
 from cinder import utils
 
 
-LOG = logging.getLogger('cinder.all')
-
 if __name__ == '__main__':
     flags.parse_args(sys.argv)
     logging.setup("cinder")
+    LOG = logging.getLogger('cinder.all')
+
     utils.monkey_patch()
     servers = []
     # cinder-api
     try:
         servers.append(service.WSGIService('osapi_volume'))
     except (Exception, SystemExit):
-        logging.exception(_('Failed to load %s') % '%s-api' % api)
+        LOG.exception(_('Failed to load osapi_volume'))
 
     for binary in ['cinder-volume', 'cinder-scheduler']:
         try: