]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Add retry to lvm delete
authorJohn Griffith <john.griffith@solidfire.com>
Wed, 29 Apr 2015 23:25:12 +0000 (17:25 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Wed, 29 Apr 2015 23:27:49 +0000 (17:27 -0600)
Seems we have another issue related to lvm and
snapshots, but this time it's on the delete side.

We used a simple retry mechanism for snapshot create
here:
  https://review.openstack.org/#/c/149360/8

I'm hesitant to just add another retry without looking
at dm issues, but this should address the problem
temporarily and give us a chance to collect some
data on the issue.

Change-Id: I37607a09e2f9af6f2f32ddfaa8567400541e533a
Closes-Bug: #1450110

cinder/brick/local_dev/lvm.py

index 9a0c26464ece15492e44c3e1a5927bc85b9e4d22..f4c7753c807a7081a6df01f0005d84397e6bda33 100644 (file)
@@ -625,6 +625,7 @@ class LVM(executor.Executor):
             LOG.error(_LE('StdErr  :%s'), err.stderr)
             raise
 
+    @utils.retry(putils.ProcessExecutionError)
     def delete(self, name):
         """Delete logical volume or snapshot.