]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Added the missing attachment to detach_volume
authorWalter A. Boring IV <walter.boring@hp.com>
Wed, 25 Mar 2015 16:35:51 +0000 (09:35 -0700)
committerWalter A. Boring IV <walter.boring@hp.com>
Wed, 25 Mar 2015 17:03:05 +0000 (10:03 -0700)
I must have missed this driver in the multiattach
patch.   The attachment object is passed in to
detach_volume to give drivers a chance to deal with
a detach call.

This patch just updates the signature of the method
to be the same as the parent.

Change-Id: I895c163e67d35df202a5490a7a31ee7fc13a0cb4
Closes-Bug: #1436367

cinder/volume/drivers/openvstorage.py

index 7dc643d84c49e5e33cb373b76efcdd499f9e94b5..050ee7eeb7ad55da97c80ec8519ebc2f48d8cf46 100644 (file)
@@ -383,7 +383,7 @@ class OVSVolumeDriver(driver.VolumeDriver):
         """Callback for volume attached to instance or host."""
         pass
 
-    def detach_volume(self, context, volume):
+    def detach_volume(self, context, volume, attachment=None):
         """Callback for volume detached."""
         pass