]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
(type) Fixed bug which arbitrarily limited which chains iniface and outiface paramete...
authorDaniel Kuehn <daniel@kuehn.se>
Fri, 6 Jun 2014 15:25:14 +0000 (17:25 +0200)
committerDaniel Kuehn <daniel@kuehn.se>
Fri, 6 Jun 2014 15:25:14 +0000 (17:25 +0200)
lib/puppet/type/firewall.rb

index e6be89e25c20ae943bf99229a73c9bdcebb9faf6..dd0998241eb968f35b4d66deb2129e532121017a 100644 (file)
@@ -973,20 +973,6 @@ Puppet::Type.newtype(:firewall) do
 
     # Now we analyse the individual properties to make sure they apply to
     # the correct combinations.
-    if value(:iniface)
-      unless value(:chain).to_s =~ /INPUT|FORWARD|PREROUTING/
-        self.fail "Parameter iniface only applies to chains " \
-          "INPUT,FORWARD,PREROUTING"
-      end
-    end
-
-    if value(:outiface)
-      unless value(:chain).to_s =~ /OUTPUT|FORWARD|POSTROUTING/
-        self.fail "Parameter outiface only applies to chains " \
-          "OUTPUT,FORWARD,POSTROUTING"
-      end
-    end
-
     if value(:uid)
       unless value(:chain).to_s =~ /OUTPUT|POSTROUTING/
         self.fail "Parameter uid only applies to chains " \